-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rename new abstract components to keep name for legacy components
- Loading branch information
Tobias
committed
Sep 21, 2019
1 parent
97bd162
commit 7a523f4
Showing
39 changed files
with
289 additions
and
89 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
packages/core/src/common/abstractComponentNewLifecycles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
| import { isNodeEnv } from "./utils"; | ||
|
|
||
| /** | ||
| * An abstract component that Blueprint components can extend | ||
| * in order to add some common functionality like runtime props validation. | ||
| */ | ||
| export abstract class AbstractComponentNewLifecycles<P, S, SS = {}> extends React.Component<P, S, SS> { | ||
| /** Component displayName should be `public static`. This property exists to prevent incorrect usage. */ | ||
| protected displayName: never; | ||
|
|
||
| // Not bothering to remove entries when their timeouts finish because clearing invalid ID is a no-op | ||
| private timeoutIds: number[] = []; | ||
|
|
||
| protected constructor(props?: P, context?: any) { | ||
| super(props, context); | ||
| if (!isNodeEnv("production")) { | ||
| this.validateProps(this.props, true); | ||
| } | ||
| } | ||
|
|
||
| public componentDidUpdate(_: P, __: S, ___: SS) { | ||
| if (!isNodeEnv("production")) { | ||
| this.validateProps(this.props); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Ensures that the props specified for a component are valid. | ||
| * Implementations should check that props are valid and usually throw an Error if they are not. | ||
| * Implementations should not duplicate checks that the type system already guarantees. | ||
| * | ||
| * This method should be used instead of React's | ||
| * [propTypes](https://facebook.github.io/react/docs/reusable-components.html#prop-validation) feature. | ||
| * Like propTypes, these runtime checks run only in development mode. | ||
| */ | ||
| protected validateProps(_: P, __: boolean = false) { | ||
| // implement in subclass | ||
| } | ||
|
|
||
| public componentWillUnmount() { | ||
| this.clearTimeouts(); | ||
| } | ||
|
|
||
| /** | ||
| * Set a timeout and remember its ID. | ||
| * All stored timeouts will be cleared when component unmounts. | ||
| * @returns a "cancel" function that will clear timeout when invoked. | ||
| */ | ||
| public setTimeout(callback: () => void, timeout?: number) { | ||
| const handle = window.setTimeout(callback, timeout); | ||
| this.timeoutIds.push(handle); | ||
| return () => window.clearTimeout(handle); | ||
| } | ||
|
|
||
| /** | ||
| * Clear all known timeouts. | ||
| */ | ||
| public clearTimeouts = () => { | ||
| if (this.timeoutIds.length > 0) { | ||
| for (const timeoutId of this.timeoutIds) { | ||
| window.clearTimeout(timeoutId); | ||
| } | ||
| this.timeoutIds = []; | ||
| } | ||
| }; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
packages/core/src/common/abstractPureComponentNewLifecycles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import * as React from "react"; | ||
| import { isNodeEnv } from "./utils"; | ||
|
|
||
| /** | ||
| * An abstract component that Blueprint components can extend | ||
| * in order to add some common functionality like runtime props validation. | ||
| */ | ||
| export abstract class AbstractPureComponentNewLifecycles<P, S = {}, SS = {}> extends React.PureComponent<P, S, SS> { | ||
| /** Component displayName should be `public static`. This property exists to prevent incorrect usage. */ | ||
| protected displayName: never; | ||
|
|
||
| // Not bothering to remove entries when their timeouts finish because clearing invalid ID is a no-op | ||
| private timeoutIds: number[] = []; | ||
|
|
||
| constructor(props?: P, context?: any) { | ||
| super(props, context); | ||
| if (!isNodeEnv('production')) { | ||
| this.validateProps(this.props, true); | ||
| } | ||
| } | ||
|
|
||
| public componentDidUpdate(_: P, __: S, ___: SS) { | ||
| if (!isNodeEnv('production')) { | ||
| this.validateProps(this.props); | ||
| } | ||
| } | ||
|
|
||
| public componentWillUnmount() { | ||
| this.clearTimeouts(); | ||
| } | ||
|
|
||
| /** | ||
| * Set a timeout and remember its ID. | ||
| * All stored timeouts will be cleared when component unmounts. | ||
| * @returns a "cancel" function that will clear timeout when invoked. | ||
| */ | ||
| public setTimeout(callback: () => void, timeout?: number) { | ||
| const handle = window.setTimeout(callback, timeout); | ||
| this.timeoutIds.push(handle); | ||
| return () => window.clearTimeout(handle); | ||
| } | ||
|
|
||
| /** | ||
| * Clear all known timeouts. | ||
| */ | ||
| public clearTimeouts = () => { | ||
| if (this.timeoutIds.length > 0) { | ||
| for (const timeoutId of this.timeoutIds) { | ||
| window.clearTimeout(timeoutId); | ||
| } | ||
| this.timeoutIds = []; | ||
| } | ||
| }; | ||
|
|
||
| /** | ||
| * Ensures that the props specified for a component are valid. | ||
| * Implementations should check that props are valid and usually throw an Error if they are not. | ||
| * Implementations should not duplicate checks that the type system already guarantees. | ||
| * | ||
| * This method should be used instead of React's | ||
| * [propTypes](https://facebook.github.io/react/docs/reusable-components.html#prop-validation) feature. | ||
| * Like propTypes, these runtime checks run only in development mode. | ||
| */ | ||
| protected validateProps(_: P, __: boolean = false) { | ||
| // implement in subclass | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.