Split karma testing into more CI containers (#3638)

palantir · Jul 1, 2019 · 35d8079 · 35d8079 · blueprint-bot · Jul 1, 2019
1 parent 8399362
commit 35d8079
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 19 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -98,18 +98,24 @@ jobs:
     docker: *docker-node-browsers
     environment:
       JUNIT_REPORT_PATH: reports
-    parallelism: 3
+    parallelism: 6
     steps:
       - checkout
       - restore_cache: *restore-node-modules-cache
       - attach_workspace: { at: '.' }
       - run: mkdir ./reports
       - run:
+          # split karma tests into containers because they can take up a lot of memory
+          # running them in one container caused Karma to time out frequently
+          # see https://github.com/palantir/blueprint/issues/3616
           command: |
               case $CIRCLE_NODE_INDEX in \
-              0) yarn lerna run --parallel test:pre ;; \
-              1) yarn lerna run --parallel test:iso ;; \
-              2) yarn lerna run --parallel test:karma ;; \
+              0) yarn lerna run --parallel test:typeCheck ;; \
+              1) yarn lerna run --scope "@blueprintjs/core" test:karma ;; \
+              2) yarn lerna run --scope "@blueprintjs/datetime" test:karma ;; \
+              3) yarn lerna run --scope "@blueprintjs/select" test:karma ;; \
+              4) yarn lerna run --scope "@blueprintjs/table" test:karma ;; \
+              5) yarn lerna run --scope "@blueprintjs/timezone" test:karma ;; \
               esac
           when: always
       - store_test_results: { path: ./reports }
@@ -122,6 +128,26 @@ jobs:
       JUNIT_REPORT_PATH: reports
       REACT: 15 # use React 15 for this job
 
+  test-iso-react-16: &test-iso
+    docker: *docker-node-lts
+    environment:
+      JUNIT_REPORT_PATH: reports
+    steps:
+      - checkout
+      - restore_cache: *restore-node-modules-cache
+      - attach_workspace: { at: '.' }
+      - run: mkdir ./reports
+      - run: yarn lerna run --parallel test:iso
+      - store_test_results: { path: ./reports }
+      - store_artifacts: { path: ./reports }
+
+  test-iso-react-15:
+    # copy test-iso-react-16 and override environment
+    <<: *test-iso
+    environment:
+      JUNIT_REPORT_PATH: reports
+      REACT: 15 # use React 15 for this job
+
   deploy-preview:
     docker: *docker-node-lts
     steps:
@@ -160,10 +186,14 @@ workflows:
           requires: [compile]
       - test-react-16:
           requires: [compile]
+      - test-iso-react-15:
+          requires: [compile]
+      - test-iso-react-16:
+          requires: [compile]
       - deploy-preview:
           requires: [dist]
       - deploy-npm:
-          requires: [dist, lint, test-react-15, test-react-16]
+          requires: [dist, lint, test-react-15, test-react-16, test-iso-react-15, test-iso-react-16]
           filters:
             branches:
               only:

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -32,8 +32,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",

diff --git a/packages/datetime/package.json b/packages/datetime/package.json
@@ -27,8 +27,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",

diff --git a/packages/icons/package.json b/packages/icons/package.json
@@ -29,8 +29,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "verify": "npm-run-all compile -p dist test lint"
   },

diff --git a/packages/labs/package.json b/packages/labs/package.json
@@ -27,8 +27,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",
     "verify": "npm-run-all compile -p dist test lint"

diff --git a/packages/select/package.json b/packages/select/package.json
@@ -27,8 +27,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",

diff --git a/packages/table/package.json b/packages/table/package.json
@@ -27,8 +27,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",

diff --git a/packages/timezone/package.json b/packages/timezone/package.json
@@ -27,8 +27,8 @@
     "lint:scss": "sass-lint",
     "lint:ts": "ts-lint",
     "lint-fix": "ts-lint --fix",
-    "test": "run-s test:pre test:iso test:karma",
-    "test:pre": "tsc -p ./test",
+    "test": "run-s test:typeCheck test:iso test:karma",
+    "test:typeCheck": "tsc -p ./test",
     "test:iso": "mocha test/isotest.js",
     "test:karma": "karma start",
     "test:karma:debug": "karma start --single-run=false --reporters=mocha --debug",