Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

Conversation

@svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Mar 12, 2023

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

4.189.0

Type Description Link
Improvement Upgrade error_prone to 2.18.0 (from 2.16) palantir/gradle-baseline#2472

4.190.0

Type Description Link
Feature Added DangerousCollapseKeysUsage error prone check to disallow usage of collapseKeys() API of EntryStream. palantir/gradle-baseline#2291
Feature Prefer common versions of annotations over other copies palantir/gradle-baseline#2505

4.191.0

Type Description Link
Feature Add error-prone check JooqBatchWithoutBindArgs palantir/gradle-baseline#2506

4.192.0

Automated release, no documented user facing changes

5.0.0

Type Description Link
Break Remove support for refaster palantir/gradle-baseline#2521

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 2 times, most recently from b1b4a2a to 8768919 Compare March 16, 2023 02:06
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch from 8768919 to dd680dd Compare March 16, 2023 16:38
this.physicalBoundStoreStrategy = physicalBoundStoreStrategy;
}

@SuppressWarnings("GuardedBy") // TODO (jkong): synchronize?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd and scary to suppress. I think we want something like the following instead:

    private volatile DBType dbType;
    private DBType getDbType(Connection connection) {
        DBType type = this.dbType; // volatile read
        if (type == null) {
            synchronized (this) {
                type = this.dbType;
                if (type == null) {
                    type = ConnectionDbTypes.getDbType(connection);
                    this.dbType = type;
                }
            }
        }
        return type;
    }

@Override
@SuppressWarnings("checkstyle:NoFinalizer") // TODO (jkong): Can we safely remove this without breaking things?
@SuppressWarnings({"checkstyle:NoFinalizer", "Finalize"}) // TODO (jkong): Can we safely remove this without
// breaking things?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should migrate any finalize() to JDK Cleaner APIs as finalizer is deprecated in JDK 18 per JEP 421 and will be removed in the future. See also https://bugs.openjdk.org/browse/JDK-8253568

@schlosna
Copy link
Contributor

#6710 builds off this branch to fix up the build and clean up error-prone checks

@bulldozer-bot bulldozer-bot bot merged commit 6719e09 into develop Sep 7, 2023
@bulldozer-bot bulldozer-bot bot deleted the roomba/latest-baseline-oss branch September 7, 2023 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants