Skip to content

Conversation

@sgaist
Copy link
Contributor

@sgaist sgaist commented Feb 5, 2025

Summary

This PR adds all poetry versions from 1.8.4 up to current (at the time of PR creation) 2.1.2

Fixes #472
Supersedes #470

Use Cases

Allow buildpack user to have more recent versions of poetry at their disposal.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sgaist sgaist requested a review from a team as a code owner February 5, 2025 13:58
@katrilh
Copy link

katrilh commented Apr 9, 2025

@sgaist or potentially @arjun024 any chance we can get some attention to this PR and get it approved/merged? 🤞🏼

@sgaist
Copy link
Contributor Author

sgaist commented Apr 9, 2025

@katrilh As the PR author, what can I do to help move it forward ?

@katrilh
Copy link

katrilh commented Apr 10, 2025

@sgaist Do you know of a way to bump this for the paketo-buildpacks/python-maintainer-group?
Thank you so much for opening the PR ❤️ This opening this PR -- poetry has released versions upto 2.1.2 any chance could be added in too?

@a1flecke
Copy link

@katrilh @sgaist I am also very interested in this PR. I started a discussion asking how to get attention to this PR. So far, no info.

@sgaist sgaist changed the title feat: add poetry 1.8.4 -> 2.0.1 feat: add poetry 1.8.4 -> 2.1.2 Apr 20, 2025
@sgaist
Copy link
Contributor Author

sgaist commented Apr 20, 2025

@katrilh new versions added as requested :-)

@a1flecke another possible thing to do is join one of the community calls and check with the folks there if there's something that could be done to help push things forward.

@jericop
Copy link
Contributor

jericop commented Apr 21, 2025

Apologies for not seeing this sooner. I'm taking a look.

@jericop jericop added the semver:minor A change requiring a minor version bump label Apr 21, 2025
v3 has been deprecated and disabled.
@sgaist
Copy link
Contributor Author

sgaist commented Apr 24, 2025

@jericop I updated the version of actions/upload-artifact to v4 which should also fix other automated pipelines that are failing such as the one that should do the auto-update.

@jericop
Copy link
Contributor

jericop commented Apr 26, 2025

Thanks for updating the upload-artifact from v3 to v4. I reviewed the migration guide and was not sure if it would cause any failures due to overwrites no longer allowed by default, so I went ahead and tested it and it looks like it should be good to go. You can ignore my closed PRs on your fork. Those were opened by mistake.

One more thing that you could add to this PR to avoid the push-buildpack workflow from failing is to disable GCR image push by commenting it out here.
https://github.com/idiap/paketo-buildpacks-poetry/blob/21738b75cf844a9a0b3e6c5a09d142c9d0619112/.github/workflows/push-buildpackage.yml#L42-L50

After that it should be good to go.

As requested on the PR.
@sgaist
Copy link
Contributor Author

sgaist commented Apr 27, 2025

@jericop Done as requested !

Should the GCR disabling be applied to other buildpacks as well ?

I was thinking about going through the python related buildpacks to fix the upload-artifact actions.

@jericop
Copy link
Contributor

jericop commented Apr 27, 2025

Should the GCR disabling be applied to other buildpacks as well ?

I was thinking about going through the python related buildpacks to fix the upload-artifact actions.

That would be great. Thank you!

@jericop jericop merged commit af680c4 into paketo-buildpacks:main Apr 27, 2025
12 checks passed
@sgaist sgaist deleted the feat/update-poetry-versions branch April 28, 2025 07:46
@mzuber
Copy link

mzuber commented Apr 30, 2025

@jericop Bringing this change upstream seems to require some changes to the integration tests in the paketo-buildpacks/python buildpack. I tried to address this in paketo-buildpacks/python#1028, maybe you can have a look into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor A change requiring a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Poetry V2

5 participants