-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add poetry 1.8.4 -> 2.1.2 #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add poetry 1.8.4 -> 2.1.2 #473
Conversation
|
@katrilh As the PR author, what can I do to help move it forward ? |
|
@sgaist Do you know of a way to bump this for the |
|
@katrilh @sgaist I am also very interested in this PR. I started a discussion asking how to get attention to this PR. So far, no info. |
|
Apologies for not seeing this sooner. I'm taking a look. |
v3 has been deprecated and disabled.
|
@jericop I updated the version of |
|
Thanks for updating the upload-artifact from v3 to v4. I reviewed the migration guide and was not sure if it would cause any failures due to overwrites no longer allowed by default, so I went ahead and tested it and it looks like it should be good to go. You can ignore my closed PRs on your fork. Those were opened by mistake. One more thing that you could add to this PR to avoid the push-buildpack workflow from failing is to disable GCR image push by commenting it out here. After that it should be good to go. |
As requested on the PR.
|
@jericop Done as requested ! Should the GCR disabling be applied to other buildpacks as well ? I was thinking about going through the python related buildpacks to fix the upload-artifact actions. |
That would be great. Thank you! |
|
@jericop Bringing this change upstream seems to require some changes to the integration tests in the |
Summary
This PR adds all poetry versions from 1.8.4 up to current (at the time of PR creation) 2.1.2
Fixes #472
Supersedes #470
Use Cases
Allow buildpack user to have more recent versions of poetry at their disposal.
Checklist