Repository navigation
Always set and default REGISTRY_PUBLISH in the test pipeline - #1920
Merged
Merged
Conversation
Restore the REGISTRY_PUBLISH env var (renamed from TTL_SH_PUBLISH) to the package-buildpack step of the create-package test job used by buildpacks without integration tests, and guard the script against an unset variable. Under `set -u`, referencing an unbound REGISTRY_PUBLISH aborted the job with a 'REGISTRY_PUBLISH: unbound variable' error.
dmikusa
added
type:bug
This was referenced Aug 10, 2026
This was referenced Aug 11, 2026
This was referenced Aug 10, 2026
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When pipeline 1.47.1 renamed
TTL_SH_PUBLISHtoREGISTRY_PUBLISH(for the local registry integration-test change), the env var was dropped from thePackage Buildpackstep of theCreate Package Testjob used by buildpacks without integration tests (e.g. microsoft-openjdk). Becausepackage-buildpack.shruns underset -u, the job aborted withREGISTRY_PUBLISH: unbound variable:paketo-buildpacks/microsoft-openjdk#412
Changes
REGISTRY_PUBLISH: "false"in thePackage Buildpackstep env inocto/test.go(the same pattern as the priorTTL_SH_PUBLISH: "false").octo/package-buildpack.shdefensive:if [ "${REGISTRY_PUBLISH:-}" = "true" ]so an unset variable no longer triggers the unbound-variable error.Validated by regenerating the microsoft-openjdk workflows and pushing to PR 412, where
Create Package Testwent green.