Allow additional build args for pack build #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea |
c0d1ngm0nk3y
force-pushed
the
additional-build-args
branch
from
cb32748
to
f9a9507
Compare
|
Looks good to me - you might need to rebase against main since I just merged in your other PR there are conflicts now |
Signed-off-by: Ralf Pannemans <[email protected]>
c0d1ngm0nk3y
force-pushed
the
additional-build-args
branch
from
f9a9507
to
27cc29d
Compare
That was fast. Thanks :)
I was aware, but I thought it might be clearer to keep them separate. I resolved the conflicts. |
robdimsdale
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows to add additional arguments to
pack buildthat were not added yet in the fluent interface.Use Cases
When you realise in your test that a specific
pack buildargument is not yet supported by the fluent interface, this offers some mitigation. Otherwise, you would have to delay the test or use shell out and notoccam.Pack.Checklist