Support testing when Docker is not running locally #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent changes to Docker licensing, a user may not be running Docker on localhost. The occam code assumes that a test application will be accessible on `localhost` though. If you have a set up where Docker is running in a custom VM or even remotely. The occam matchers will always fail because nothing is available on localhost. This PR makes adjustments so that you can configure a remote host. It will look at and parse `DOCKER_HOST`. If not set, then it defaults to `localhost` which preserves the current behavior. If set, it will parse the URL and return the hostname so long as it's not a `unix://` socket. Signed-off-by: Daniel Mikusa <[email protected]>
sophiewigmore
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes adjustments so that you can configure a remote host. It will look at and parse
DOCKER_HOST. If not set, then it defaults tolocalhostwhich preserves the current behavior. If set, it will parse the URL and return the hostname so long as it's not aunix://socket.Use Cases
With the recent changes to Docker licensing, a user may not be running Docker on localhost. The occam code assumes that a test application will be accessible on
localhostthough. If you have a set up where Docker is running in a custom VM or even remotely. The occam matchers will always fail because nothing is available on localhost.Checklist