Skip to content

Adds summary to legacy SBOM output in create-stack #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sophiewigmore merged 1 commit into from
Jun 14, 2022
Merged

Adds summary to legacy SBOM output in create-stack #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/ihop/sbom.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ type LegacySBOMPackage struct {
Version string `json:"version"`
Arch string `json:"arch"`
Source *LegacySBOMPackageSource `json:"source,omitempty"`
Summary string `json:"summary,omitempty"`
}

// LegacySBOMPackageSource represents a package source as defined in the legacy
Expand Down Expand Up @@ -98,7 +99,7 @@ func (s SBOM) LegacyFormat() (string, error) {
Version: metadata.SourceVersion,
UpstreamVersion: upstreamVersion,
},
// TODO: Summary
Summary: strings.SplitN(metadata.Description, "\n", 2)[0],
})

case pkg.ApkMetadata:
Expand Down
4 changes: 3 additions & 1 deletion internal/ihop/sbom_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func testSBOM(t *testing.T, context spec.G, it spec.S) {
Architecture: "arm64",
Source: "c-package-source",
SourceVersion: "3.1.2-upstream-ubuntu3",
Description: "a package for c\n provides a bunch of c stuff",
},
},
pkg.Package{
Expand Down Expand Up @@ -103,7 +104,8 @@ func testSBOM(t *testing.T, context spec.G, it spec.S) {
"name": "c-package-source",
"version": "3.1.2-upstream-ubuntu3",
"upstreamVersion": "3.1.2-upstream"
}
},
"summary": "a package for c"
}
]`))
})
Expand Down