-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default browser selection for opening links & video calls #255
Comments
This is how we can detect what browsers are installed.
And that's how we can launch a URL inside the selected one.
That's how to get browser icons.
Getting browser name.
|
I have a working browser as well. I use an app called Finicky as my "default browser" and I configure which browser should open the URL. module.exports = {
defaultBrowser: "Safari",
handlers: [
{
match: [
"notion.*/*",
"*.notion.*/*",
"linear.app/*",
"*.linear.app/*",
"play.google.com/*",
"developers.facebook.com/*",
'*.figma.com/*',
'console.cloud.google.com/*',
"*.aws.amazon.com/*",
],
/*browser: {
name: "Google Chrome",
profile: "Profile 1"
}*/
browser: ({ urlString }) => ({
name: "Firefox",
args: ["-P", "Profile 1", `${urlString}`]
})
}
]
} That has the advantage of being system-wide, so if I click a link on Slack, for example, it also routes to my work browser. |
@pakerwreah But probably would be nice to have it in the Calendr app in some form too, since most users don't have such helper apps. |
I think when I have time I'll work on it and come up with a PR. |
The problem is that a context menu will not be helpful, as it will become extremely frustrating and repetitive. That said, it should be pretty simple, actually. You don't have to map every browser. Feel free to implement this, but I'm probably not going to merge it, as it's beyond the scope of Calendr. |
@pakerwreah |
@pakerwreah |
@pakerwreah Also, found several issues: |
Also, just a question to consider. I also think if it's a default browser, after selection the browser option it can be without the icon, like in the 1. bug I showed you. And if it's not default, then it will be with the icon. So that by default it's not intrusive if we are talking about the preferences. But it's subjective and personally I like the icons always. |
Yeah, I wrongly assumed that I was only showing native apps as video calls. I forgot about google meet/hangouts. About moving it to preferences, it would have to be per calendar, that's why I don't want to do it there. |
@pakerwreah Definitely it would be enough to just have it near the links/video calls. |
I completely forgot to open the link 🤣
👉🏻 |
@pakerwreah |
@pakerwreah |
Hum 🤔 it should always show the default first. Than can cause problems, let me have a look. |
yeah, I'm just dumb and don't know how to sort multiple keys 😆 we're almost there... Calendr.zip |
@pakerwreah |
Hi!
My use case is that I moved my working calendar to Apple Calendar to use with Calendr app. There I have a lot of video calls with links.
But my default browser is not my working browser, so wherever I click the events to open the meetings (Google Meets mostly), it launches them in the wrong browser and I have to copy the link and open it in another browser.
My idea is that it would be really great to set the default browser for opening links in the Calendr Settings.
Or, provide the option to open it in a specific browser (after right clicking near
Join
), like in the Mail app:Or, have the option to
Copy link
here, so that I can insert it where I need to without launching the meeting in the wrong browser first. I know the link is available in the event details, but I have a long description there and it's not convenient to copy the link from the details.What do you think about these ideas?
The text was updated successfully, but these errors were encountered: