Allow int and float to use as cache keys

paillechat · Jun 1, 2017 · 1096359 · 1096359
1 parent b0ffb35
commit 1096359
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/ApcuCache.php b/src/ApcuCache.php
@@ -165,7 +165,7 @@ private function buildKeyNames(array $keys)
      */
     private function assertKeyName($key)
     {
-        if (!is_string($key)) {
+        if (!is_scalar($key) || is_bool($key)) {
             throw new ApcuInvalidCacheKeyException();
         }
     }

diff --git a/tests/ApcuCacheTest.php b/tests/ApcuCacheTest.php
@@ -124,15 +124,33 @@ public function dataForTestGetWithInvalidKey()
     {
         return [
             'null' => [null],
-            'int' => [1],
-            'float' => [1.1],
             'object' => [new \stdClass()],
             'array' => [[]],
             'bool' => [false],
             'resource' => [fopen('/tmp/test.1', 'w+')],
         ];
     }
 
+    /**
+     * @dataProvider dataForTestSetAndGetWithAllowedKeys
+     *
+     * @param $key
+     */
+    public function testSetAndGetWithAllowedKeys($key)
+    {
+        $this->cache->set($key, 'foo');
+        $this->assertEquals('foo', $this->cache->get($key));
+    }
+
+    public function dataForTestSetAndGetWithAllowedKeys()
+    {
+        return [
+            [5],
+            [1.1],
+            ['bar'],
+        ];
+    }
+
     public function testWhenApcuUnavailable()
     {
         ini_set('apc.enable_cli', 0);