Skip to content

fix(cd): track asset-registry cmd/main.go and add load-generator Dockerfile#11

Merged
pahuldeepp merged 1 commit intomasterfrom
fix/cd-missing-assets
Mar 28, 2026
Merged

fix(cd): track asset-registry cmd/main.go and add load-generator Dockerfile#11
pahuldeepp merged 1 commit intomasterfrom
fix/cd-missing-assets

Conversation

@pahuldeepp
Copy link
Copy Markdown
Owner

Summary

  • apps/asset-registry/cmd/main.go was excluded by the top-level cmd/ pattern in .gitignore; force-tracked so the CD Docker build can find the entry-point
  • apps/load-generator/ had no Dockerfile; added one that matches the flat main.go layout used by this tool service

Test plan

  • CI passes (no Go/TS changes)
  • CD Build & Push — asset-registry succeeds
  • CD Build & Push — load-generator succeeds

🤖 Generated with Claude Code

…ckerfile

- asset-registry/cmd/main.go was gitignored by the top-level `cmd/`
  pattern; force-track it so the Docker build has the entry-point file
- load-generator had no Dockerfile; add one matching the flat main.go
  layout used by this tool service

Fixes the two failing CD Build & Push jobs on master.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 28, 2026

Warning

Rate limit exceeded

@pahuldeepp has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 15 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 2 minutes and 15 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1302c32b-786f-4b8a-9a2f-7fe14fca2d92

📥 Commits

Reviewing files that changed from the base of the PR and between 2a5a6b1 and ab7a0d0.

📒 Files selected for processing (2)
  • apps/asset-registry/cmd/main.go
  • apps/load-generator/Dockerfile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cd-missing-assets

Comment @coderabbitai help to get the list of available commands and usage tips.

@pahuldeepp pahuldeepp mentioned this pull request Mar 28, 2026
@pahuldeepp pahuldeepp merged commit 6d14360 into master Mar 28, 2026
59 checks passed
pahuldeepp added a commit that referenced this pull request Mar 28, 2026
HIGH PRIORITY:
- #9: Fix CSRF timing attack — pad buffers to fixed length before timingSafeEqual
- #10: Upgrade circuit breaker to distributed (Redis-backed state sharing across pods)
- #8: Fix saga recovery infinite loop — mark corrupted payloads as FAILED instead of retrying

MEDIUM PRIORITY:
- #11: Add webhook idempotency check (dedup by endpoint_id + event_type)
- #12: Assert Stripe webhook body is Buffer before signature verification
- #13: Eliminate N+1 query in deviceTelemetry resolver (single JOIN query)
- #15: Add ORDER BY + LIMIT to saga FindByCorrelationID for deterministic results
- #17: Make critical audit events (auth, admin) throw on failure instead of silent swallow

LOW PRIORITY:
- #20: Add 10s query timeout to all saga repository DB operations
- #23: Add IsValidStatus validator for saga status constants
- #24: Set httpServer.timeout (30s) and keepAliveTimeout (65s) on BFF
- #25: Add RabbitMQ heartbeat (30s) and connection error/close handlers
- #7: Fix remaining saga JSON marshal error check (initialErr)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant