Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175336094] Improved metadata update and validation for required fields #139

Merged
merged 9 commits into from
Oct 22, 2020

Conversation

infantesimone
Copy link
Contributor

@infantesimone infantesimone commented Oct 20, 2020

This PR introduces:

  • handle metadata for new subscriptions;
  • handle metadata keys with ServiceMetadata for dynamic metadata form:
         const metadataKeys = ServiceMetadata.type.types.reduce(
           (p, e) => [...p, ...Object.keys(e.props)],
           [] as readonly string[]
         );
    
    for this update typescript 3.4.4 (according to here);
  • check for all required fields of a subscription: when there is an invalid field, an error message is shown and the update button is disabled;

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Oct 20, 2020

Affected stories

  • 🌟 #175336094: Come ADM voglio poter inserire i metadata in una subscription nuova

New dependencies added: @types/jest, jest and ts-jest.

@types/jest

Author: Unknown

Description: TypeScript definitions for Jest

Homepage: http://npmjs.com/package/@types/jest

Createdover 4 years ago
Last Updated2 days ago
LicenseMIT
Maintainers1
Releases143
Direct Dependenciesjest-diff and pretty-format
README

Installation

npm install --save @types/jest

Summary

This package contains type definitions for Jest (https://jestjs.io/).

Details

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest.

Additional Details

  • Last updated: Tue, 20 Oct 2020 07:15:43 GMT
  • Dependencies: @types/jest-diff, @types/pretty-format
  • Global values: afterAll, afterEach, beforeAll, beforeEach, describe, expect, fail, fdescribe, fit, it, jasmine, jest, pending, spyOn, test, xdescribe, xit, xtest

Credits

These definitions were written by Asana (https://asana.com)
// Ivo Stratev
, jwbay, Alexey Svetliakov, Alex Jover Morales, Allan Lukwago, Ika, Waseem Dahman, Jamie Mason, Douglas Duteil, Ahn, Josh Goldberg, Jeff Lau, Andrew Makarov, Martin Hochel, Sebastian Sebald, Andy, Antoine Brault, Gregor Stamać, ExE Boss, Alex Bolenok, Mario Beltrán Alarcón, Tony Hallett, Jason Yu, Devansh Jethmalani, Pawel Fajfer, and Regev Brody.

jest

Author: Unknown

Description: Delightful JavaScript Testing.

Homepage: https://jestjs.io/

Createdover 8 years ago
Last Updated3 days ago
LicenseMIT
Maintainers8
Releases258
Direct Dependencies@jest/core, import-local and jest-cli
Keywordsava, babel, coverage, easy, expect, facebook, immersive, instant, jasmine, jest, jsdom, mocha, mocking, painless, qunit, runner, sandboxed, snapshot, tap, tape, test, testing, typescript and watch
README

Jest

🃏 Delightful JavaScript Testing

  • 👩🏻‍💻 Developer Ready: Complete and ready to set-up JavaScript testing solution. Works out of the box for any React project.

  • 🏃🏽 Instant Feedback: Failed tests run first. Fast interactive mode can switch between running all tests or only test files related to changed files.

  • 📸 Snapshot Testing: Jest can capture snapshots of React trees or other serializable values to simplify UI testing.

Read More: https://jestjs.io/

ts-jest

Author: Kulshekhar Kabra

Description: A preprocessor with source maps support to help use TypeScript with Jest

Homepage: https://kulshekhar.github.io/ts-jest

Createdabout 4 years ago
Last Updated23 days ago
LicenseMIT
Maintainers3
Releases127
Direct Dependencies@types/jest, bs-logger, buffer-from, fast-json-stable-stringify, jest-util, json5, lodash.memoize, make-error, mkdirp, semver and yargs-parser
Keywordsjest, typescript, sourcemap, react and testing
README

ts-jest

npm version
NPM downloads
Known Vulnerabilities
Coverage Status
Build Status
doc-generator
release-and-publish

ts-jest is a TypeScript preprocessor with source map support for Jest that lets you use Jest to test projects written in TypeScript.

It supports all features of TypeScript including type-checking. Read more about Babel7 + preset-typescript vs TypeScript (and ts-jest).


We are not doing semantic versioning and 23.10 is a re-write, run npm i -D ts-jest@"<23.10.0" to go back to the previous version

View the online documentation (usage & technical)

Ask for some help in the ts-jest community of Slack

Before reporting any issue, be sure to check the troubleshooting page

We're looking for collaborators! Want to help improve ts-jest?


Getting Started

These instructions will get you setup to use ts-jest in your project. For more detailed documentation, please check online documentation.

using npm using yarn
Prerequisites npm i -D jest typescript yarn add --dev jest typescript
Installing npm i -D ts-jest @types/jest yarn add --dev ts-jest @types/jest
Creating config npx ts-jest config:init yarn ts-jest config:init
Running tests npm t or npx jest yarn test or yarn jest

Built With

  • TypeScript - JavaScript that scales
  • Jest - Delightful JavaScript Testing
  • ts-jest - Jest processor for TypeScript (yes, ts-jest uses itself for its tests)

Contributing

Please read CONTRIBUTING.md for details on our code of conduct, and the process for submitting pull requests to us.

Versioning

We DO NOT use SemVer for versioning. Though you can think about SemVer when reading our version, except our major number follows the one of Jest. For the versions available, see the tags on this repository.

Authors/maintainers

See also the list of contributors who participated in this project.

Supporters

License

This project is licensed under the MIT License - see the LICENSE.md file for details

Generated by 🚫 dangerJS against 171974a

@infantesimone infantesimone marked this pull request as draft October 21, 2020 08:10
@infantesimone infantesimone marked this pull request as ready for review October 21, 2020 13:13
@balanza balanza merged commit 67af38a into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants