Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [P4PU-338] Storybook components #90

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

mmoio
Copy link
Collaborator

@mmoio mmoio commented Jul 26, 2024

List of Changes

  • Storybook pinned 8.1.11
  • Vite latest
  • Adds missing components stories
  • Storybook render tree refactoring

Motivation and Context

This pr adds missing components to storybook, It also updates storybook and vite version.
Storybook is pinned at version 8.1.11 due to issues with newer versions. For details, see the relevant issue

How Has This Been Tested?

Visual testing launching storybook with:

yarn storybook

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mmoio mmoio self-assigned this Jul 26, 2024
@mmoio mmoio requested a review from a team as a code owner July 26, 2024 08:46
@mmoio mmoio changed the title Feat: [P4PU-338] Storybook components feat: [P4PU-338] Storybook components Jul 26, 2024
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 94.14% 626/665
🟢 Branches 89.47% 221/247
🟢 Functions 82.71% 110/133
🟢 Lines 94.98% 587/618

Test suite run success

117 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from cca7cac

@mmoio mmoio merged commit f343d75 into develop Jul 26, 2024
8 of 10 checks passed
@mmoio mmoio deleted the feat/P4PU-338-storybook-components branch July 26, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants