Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [P4PU-349] signals unmocked and tested #164

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

mmoio
Copy link
Collaborator

@mmoio mmoio commented Oct 1, 2024

List of Changes

  • removes vitest setup signal mocking
  • removes signals mocks where superflous
  • increases store provider coverage
  • signals library dependency upgraded

Motivation and Context

Using vitest and the latest version of @preact/signals, the library mock is not needed anymore

How Has This Been Tested?

unit testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mmoio mmoio force-pushed the fix/P4PU-349-signals-mock-removed branch from b14acdc to dfe8cf5 Compare October 1, 2024 05:45
Copy link

github-actions bot commented Oct 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 95.25% (🎯 80%) 3311 / 3476
🔵 Statements 95.25% 3311 / 3476
🔵 Functions 85.98% 135 / 157
🟢 Branches 88.58% (🎯 80%) 326 / 368
File CoverageNo changed files found.
Generated in workflow #119 for commit dfe8cf5 by the Vitest Coverage Report Action

Copy link

sonarcloud bot commented Oct 1, 2024

@mmoio mmoio changed the title fix|tests: [P4PU-349] signals unmocked and tested fix: [P4PU-349] signals unmocked and tested Oct 1, 2024
@mmoio mmoio merged commit 854f699 into develop Oct 2, 2024
7 of 8 checks passed
@mmoio mmoio deleted the fix/P4PU-349-signals-mock-removed branch October 2, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants