-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dark theme support with @media queries #121
base: master
Are you sure you want to change the base?
Conversation
Welcome! Congrats on your first pull request to the Minimal theme. If you haven't already, please be sure to check out the contributing guidelines. |
this is for if a users device does not support changing theme based on @media querys
…-_config.yaml Support for changing theme in config.yaml
just added support for changing the theme with a config.yaml option that deafualts to auto in master brach! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
It'd be great to see this merged but in meantime, what do I put in my |
See how to https://github.com/benbalter/jekyll-remote-theme |
Co-authored-by: David Ordás <[email protected]>
Sorry for not looking at the comments for a while to use this theme follow the instructions at https://github.com/godalming123/minimal#usage and then deploy your site with github pages |
Co-authored-by: David Ordás <[email protected]>
@godalming123, to be merged as feature in github-pages you should revert changes made in theme name: I highly recommend using feature branches workflow instead coding all in In any way.... great work!!!! |
I'm probably not going to add this until maintainers see the pull request as my current goal would be to attract as many new users and that means documenting how to set this up so they can use it. And I dont even know if this repo is still maintained. |
Want a more maintained fork?If you would like a better maintained fork (as I rarely see posts here and am no longer updating this pull request as I see it as complete) see: https://github.com/BDHU/minimalist |
@parkr, as ex-github... do you know if |
This branch works however a few elements still need deferent colors for dark mode.
elements to add colors for:
elements that I have added colors for:
small
elementsmall
insidea
a
hoveredpre
color, bordera
elementI have used
@media (prefers-color-scheme){ }
queries to make this possible https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme. if you would like to see what I have done please check out https://godalming123.github.io/minimal/ the dark theme applies if your device is in dark mode and your browser supports @media prefers color scheme.