-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use css vars and @media queries to change colours depending on device theme #135
Open
godalming123
wants to merge
29
commits into
pages-themes:master
Choose a base branch
from
godalming123:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d4f0dbb
use css vars and add @media quiru to change colours
godalming123 b31159f
fix mistype
godalming123 b6ac7ef
use my variables instead of the sass ones
godalming123 f1aa60b
fix error
godalming123 5db6b9b
Set theme jekyll-theme-cayman
godalming123 6228184
fix error
godalming123 1f1c59f
add roundedness + fix bugs
godalming123 5cf0d58
fix skip to content
godalming123 1f17fa9
fix content
godalming123 9dd65fe
fix
godalming123 874d57a
update colors
godalming123 15e22fd
improve bg color
godalming123 c343245
fix code blocks
godalming123 74ce417
improve blockquote color
godalming123 eebb224
bolder headers
godalming123 119d019
use mixins and add more colours for code
godalming123 e117645
use colours for code
godalming123 c7c89fa
addmore colours for code
godalming123 25fcb4b
fix table borders not showin in dark mode
godalming123 c58e1d5
init branch
godalming123 f7dd423
fix dark mode coloring for dark and auto-deafualt-dark color schemes
godalming123 030f34f
make it clear you can customize the color scheme in config.yaml
godalming123 cccbafc
make color-scheme deafualt to auto if it is undefined
464a0ad
Merge pull request #1 from godalming123/support-for-changing-theme-wi…
c84f73d
add experminetal theme with black code blocks
810a624
fix spelling of default
15c356a
Improve the style choices
godalming123 37395cc
fix
godalming123 50942db
fix 2
godalming123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
@mixin header-colors { | ||
--header-heading-color: #fff; | ||
--header-bg-color: #159957; | ||
--header-bg-color-secondary: #155799; | ||
} | ||
|
||
@mixin light-colors { | ||
|
||
// Text | ||
--section-headings-color: #22cc77; | ||
--body-text-color: #606c71; | ||
--body-link-color: #1e6bb8; | ||
--blockquote-text-color: #819198; | ||
|
||
// Code | ||
--code-bg-color: #f3f6fa; | ||
--code-text-color: #567482; | ||
//colors | ||
--code-d14: #d14; | ||
--code-red-dark: #aa0000; | ||
--code-lightblue: #009999; | ||
--code-009926: #009926; | ||
--code-990073: #990073; | ||
--code-008080: #008080; | ||
--code-445588: #445588; | ||
--code-grey-as: #aaaaaa; | ||
--code-grey-9s: #999999; | ||
--code-grey-8s: #888888; | ||
--code-grey-5s: #555555; | ||
--code-000080: #000080; | ||
--code-990000: #990000; | ||
--code-800080: #800080; | ||
--code-3c5d5d: #3c5d5d; | ||
|
||
// Borders | ||
--border-color: #dce6f0; | ||
--table-border-color: #e9ebec; | ||
--hr-border-color: #eff0f1; | ||
|
||
// Misilainius | ||
--bg-color: white; | ||
} | ||
|
||
@mixin dark-colors { | ||
// Text | ||
--section-headings-color: #159957; | ||
--body-text-color: #ffffff; | ||
--body-link-color: #1e6bb8; | ||
--blockquote-text-color: #b4b4b4; | ||
|
||
// Code | ||
--code-bg-color: #2e2e2e; | ||
--code-text-color: #dbdbdb; | ||
--code-bold-text-color: hsl(0, 0, 100%); | ||
//colors | ||
--code-d14: #d14; | ||
--code-red-dark: #aa0000; | ||
--code-lightblue: #009999; | ||
--code-009926: #009926; | ||
--code-990073: #990073; | ||
--code-008080: #008080; | ||
--code-445588: #445588; | ||
--code-grey-as: #aaaaaa; | ||
--code-grey-9s: #999999; | ||
--code-grey-8s: #888888; | ||
--code-grey-5s: #555555; | ||
--code-000080: #000080; | ||
--code-990000: #990000; | ||
--code-800080: #800080; | ||
--code-3c5d5d: #3c5d5d; | ||
|
||
// Borders | ||
--border-color: #606468; | ||
--table-border-color: #3a3a3a; | ||
--hr-border-color: #242424; | ||
|
||
// Misilainius | ||
--bg-color:hsl(0, 0%, 10%); | ||
} | ||
|
||
@mixin experimental-black-code-block-colors { | ||
// Text | ||
--section-headings-color: #159957; | ||
--body-text-color: #ffffff; | ||
--body-link-color: #1e6bb8; | ||
--blockquote-text-color: #b4b4b4; | ||
|
||
// Code | ||
--code-bg-color: #080808; | ||
--code-text-color: #dbdbdb; | ||
--code-bold-text-color: hsl(0, 0, 100%); | ||
//colors | ||
--code-d14: #d14; | ||
--code-red-dark: #aa0000; | ||
--code-lightblue: #009999; | ||
--code-009926: #009926; | ||
--code-990073: #990073; | ||
--code-008080: #008080; | ||
--code-445588: #445588; | ||
--code-grey-as: #aaaaaa; | ||
--code-grey-9s: #999999; | ||
--code-grey-8s: #888888; | ||
--code-grey-5s: #555555; | ||
--code-000080: #000080; | ||
--code-990000: #990000; | ||
--code-800080: #800080; | ||
--code-3c5d5d: #3c5d5d; | ||
|
||
// Borders | ||
--border-color: #3c3c3c; | ||
--table-border-color: #3a3a3a; | ||
--hr-border-color: #242424; | ||
|
||
// Misilainius | ||
--bg-color:hsl(0, 0%, 10%); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: “default” is the correct spelling, multiple places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've fixed all the occurrences in my commit below. Sorry I'm not the best at spelling and the maintainers arent really keeping track of pull request so I have stopped checking this pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think defaulting to "auto" here when the original is "light" might also be an unexpected change for anyone using "latest" versions / not using a specific version of this template. Defaulting to "light" might be less risk of surprises for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I'm aware the only way that new users can come across this is if they find this PR, in which case they will only use it if they want their site to have a dark theme. Sure, if the maintainers get back to me then new people could discover it without knowing about dark theme but I think for now better to save the confusion if it does not work for people who are trying to use this theme.