[Balance] Rogue ball increase catch chance tinted pokemon

[Opaque02]

What are the changes the user will see?

Rogue balls now have a 5x chance to catch pokemon instead of 3x if the pokemon has a tinted pokeball

Why am I making these changes?

Damo wanted it

What are the changes from a developer perspective?

The main thing is that the code to find out if a pokemon has a tinted pokeball has been moved to the pokemon class under ".isPokeballTinted()". With this change, it's now possible to call from within the pokeball class by adding a pokemon field to the getPokeballCatchMultiplier. I've also added a boolean to getPokeballCatchMultiplier which is used to get the description. This is an override that lets you get the boosted rate without having to enter a pokemon as an input, which is used in the shops for the description.

Lastly, I've moved some of the text around in the shop so that for pokeballs, the number of pokeballs you have shows under the pokeball so the description section can be open for the catch rate and description if needed.

Screenshots/Videos

This wurmple below as a tinted pokeball because I didn't have the non-shiny form of it:

As you can see, it has a catch rate of 5 with rogue balls:

The wurmple below has a tinted pokeball because I don't have the ability:

Once again, it has a boosted catch rate of 5:

Below is a wurmple that does not have a tinted pokeball:

As you can see, it has a normal catch rate of 3:

In the shop, this is now what you see for rogue balls:

How to test the changes?

Download the PR and change some overrides.

Firstly, the below override will let you add 5 rogue balls to the shop to test the wording on the screen. Add this to the top section of overrides:

const overrides = {
	ITEM_REWARD_OVERRIDE: [{ name: "ROGUE_BALL", count: 5 }],
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

Secondly, you can change the pokeball overrides section to something like this:

readonly POKEBALL_OVERRIDE: { active: boolean; pokeballs: PokeballCounts } = {
    active: true,
    pokeballs: {
      [PokeballType.POKEBALL]: 5,
      [PokeballType.GREAT_BALL]: 0,
      [PokeballType.ULTRA_BALL]: 0,
      [PokeballType.ROGUE_BALL]: 99,
      [PokeballType.MASTER_BALL]: 99,
    },
  };

This will give you master balls and rogue balls you can use to test the catch rate.

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Tempo-anon]

Uncaught is not quite the same as the tinted pokeball since the tinted pokeball relates to both the specific pokemon form's dex attributes (like having owned a male charizard but not a female one) as well as the root form's ability index

[Opaque02]

Ah, that's a very good point - what wording would we want to use instead? "{{boostedCatchRate}}x for tinted pokeballs? We're a little limited on space is the only issue?

[DayKev]

Suggested change

	if (pokemon?.isTintedPokeball() || description) {
	if (enemyPokemon?.isTintedPokeball() || getBoostedDescription) {

[DayKev]

Suggested change

	const pokemon = enemyPokemon ?? null;
	const description = getBoostedDescription ?? false;

[Opaque02]

Would doing it the way I've already got it not be safer for things as a just in case? Or would it not make a difference in this case with how I've got it?

[DayKev]

null and undefined are both treated the same way in this scenario (for enemyPokemon), and both also evaluate to false when used in an if statement (for getBoostedDescription).

[Opaque02]

Perfect! I think I was in the mindset of fixing the challenges which used a similar change to what I did here - let me push a change through now!