Merged
Conversation
JP-Ellis
changed the title
This wraps the inner asynchronous function with a `::futures::executor::block_on`, allowing for asynchronous function to be more easily called by the FFI. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
feat/upgrade-mock-server-to-v2
branch
from
77a37db to
b9c8719
Compare
rholshausen
approved these changes
Dec 16, 2025
Contributor
|
No idea why the builds are failing. I tried rerunning them, but it might be they are taking too long on the MacOS agents that the agents are being killed. The v2-engine might be some regression, but your changes should not be affecting that. |
Contributor
Author
|
My guess is there's some sort of new dependency required to build the FFI, that the linker can't find when building the C example. I'll suss it out. |
The v2 mock server has a number of improvements over v1. This should be generally backwards compatible. Signed-off-by: JP-Ellis <[email protected]>
JP-Ellis
force-pushed
the
feat/upgrade-mock-server-to-v2
branch
from
b9c8719 to
d1b63ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the mock server dependency within the FFI crate to version 2.
In general, this should be backwards compatible, and should bring through to the FFI a few fixes.