Skip to content

Conversation

@YOU54F
Copy link
Member

@YOU54F YOU54F commented Apr 21, 2023

Hey @uglyog

Noted the CI workflows were throwing a few deprecation notices, and the release workflow was failing on any jobs that were for the ffi, verifier cli, or mock server cli, so this PR add's a few changes to clean up the build

  1. Update actions/checkout@v2 to actions/checkout@v3
  2. Switch deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain https://github.com/dtolnay/rust-toolchain as original unmaintained - see issue
  3. Replace marcopolo/cargo@master also unmaintained, and not sure using an action for this adds value based on what we are using from it, with a cargo rust/test/build and setting the working-directory as part of the gh action step value
  4. Remove choco install -y llvm from windows build-chain, llvm is already installed on windows runners https://github.com/actions/runner-images/blob/d8d4d924ad21a8ba4931b2988f74bbb376cad021/images/win/toolsets/toolset-2022.json#L400
  5. replace nightly-2022-12-01 with nightly - fails with updated toolchain actions update, it looks like the underlying reason for it being pinned has been fixed Cbindgen fails on latest nightly (1.68.0-nightly) with an internal compiler error rust-lang/rust#105886
  6. Skip upload release assets on the release workflow, where the tags don't correlate with a step to build artefacts.

@rholshausen
Copy link
Contributor

Nice one!

@rholshausen rholshausen merged commit 2d4fffa into pact-foundation:master May 1, 2023
@YOU54F YOU54F deleted the master-ci branch January 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cbindgen fails on latest nightly (1.68.0-nightly) with an internal compiler error

2 participants