-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatter factory method #599
Formatter factory method #599
Conversation
f68181d
to
e1d075b
Compare
Nice change! It's a biggie so appreciate you splitting out the two PR's prior, as it helped me focus on them. I'm looking at the end user interface changes in the examples, and that looks make it easier (removing an import and having as a option), considering your touched ~140 files, have minimal changes in your tests and everything green makes me a very confident person. Appreciate the diagram! So in a nutshell does this make it easier to maintainers/contributors to maintain/extend these interfaces in future? Whats the big selling point of moving to the new pattern. Looks good to me though, haven't ran it locally but he have 💚 ci |
Yes, you are correct. This is the whole point of this PR. |
e1d075b
to
b806bc9
Compare
tests/PhpPact/Consumer/Matcher/Formatters/Expression/MaxTypeFormatterTest.php
Show resolved
Hide resolved
tests/PhpPact/Consumer/Matcher/Formatters/Expression/MinTypeFormatterTest.php
Show resolved
Hide resolved
Self-reviewed |
Depend on:
Apply
Bridge
andFactory Method
design patterns to refactor formattersHere is the full diagram: