feature: Support state params coming from stateHandlers (WIP) #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noting that I'm happy to bring this in when the support is added to the verifier. Marking as a WIP. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@hhhonzik what state is this PR currently in? |
|
@hhhonzik Did you get a chance to look at the upstream work for this, or should we close this one? |
|
This PR is stale. Closing for now. |
|
It's also worth noting that this is available in the v3 beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am testing a Pact implementation to our infrastructure, however I am having some issues with the JS version of library.
While Java version has the implementation already, I can't inject any parameters from
stateHandlers.This PR allows pact-js to pass those parameters to pact-provider-verifier which should later on inject them to my pact files downloaded from a broker. While I thought this will fix things, pact-provider-verifier still doesn't support this use case.
Issue to discuss this generator here: pact-foundation/pact-provider-verifier#49