Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zombie plugin processes #435

Merged

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 3, 2024

If I run the test suite with make test - I get zombie plugin processes left in my shell

  PID TTY           TIME CMD
 1537 ttys001    0:01.26 /bin/zsh -il
 1770 ttys002    0:00.03 login -fp saf
 1772 ttys002    0:00.43 -zsh
29027 ttys007    0:00.61 /bin/zsh -il
12917 ttys014    0:00.15 /Users/saf/.pact/plugins/protobuf-0.3.15/pact-protobuf-plugin
13757 ttys014    0:00.00 /Users/saf/.pact/plugins/csv-0.0.6/pact-csv-plugin
13797 ttys014    0:00.26 /Users/saf/.pact/plugins/protobuf-0.3.15/pact-protobuf-plugin
14159 ttys014    0:00.00 ps -a
50964 ttys014    0:02.13 /bin/zsh -il

After this fix, everything still passes, and I don't have any zombie processes

  PID TTY           TIME CMD
 1537 ttys001    0:01.26 /bin/zsh -il
 1770 ttys002    0:00.03 login -fp saf
 1772 ttys002    0:00.43 -zsh
29027 ttys007    0:00.61 /bin/zsh -il
12504 ttys014    0:00.00 ps -a
50964 ttys014    0:02.08 /bin/zsh -il

@coveralls
Copy link

Coverage Status

coverage: 29.248% (+0.1%) from 29.134%
when pulling 4297634 on YOU54F:fix/zombie_plugin_processes
into c80e188 on pact-foundation:master.

@mefellows mefellows merged commit cd75a5e into pact-foundation:master Jul 4, 2024
8 checks passed
@YOU54F YOU54F deleted the fix/zombie_plugin_processes branch July 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants