Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consumer version selectors #175

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Added consumer version selectors #175

merged 1 commit into from
Aug 9, 2021

Conversation

antklim
Copy link
Contributor

@antklim antklim commented Jul 29, 2021

Description

This PR adds support for new consumer version selectors.

Related issues

@mefellows
Copy link
Member

Awesome, thanks Anton!

Minor thing - we use semantic commits to automatically generate a changelog.

I'd suggest changing your commit to something like this:

feat: support release + environment consumer version selectors

Mind updating and pushing your branch? I can get this in ASAP.

@mefellows
Copy link
Member

Oh also, you may want to look at https://github.com/pact-foundation/pact-go#v3-beta (I'll need to add the selectors there too, and in Rust so it will take a little longer to push through). But the new package isn't too far away from being the new mainline.

@mefellows mefellows merged commit f450f72 into pact-foundation:master Aug 9, 2021
@mefellows
Copy link
Member

I'll get this updated and released today @antklim - thanks for your patience!

@antklim antklim deleted the feature/new-consumer-version-selectors branch August 9, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants