New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid recompiling struct tag matching regexes #145

Merged

mefellows merged 1 commit into pact-foundation:master from mklimuk:chore/struct_regex_matcher

Jul 29, 2020

mklimuk commented Jul 29, 2020

This is a performance improvement.

We do not need to recompile regexes that match regex= and example= inside pact struct tags. I moved them into package-level vars.


          chore: avoid recompiling struct tag matching regexes

e25aa73

mefellows approved these changes

View reviewed changes

Member

mefellows left a comment

Yes nice one, thank you.

mefellows merged commit aa6e2d2 into pact-foundation:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet