Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current version don't work with latest mysql #15

Closed
Kinmarui opened this issue Jun 28, 2018 · 3 comments
Closed

current version don't work with latest mysql #15

Kinmarui opened this issue Jun 28, 2018 · 3 comments
Labels
bug Something isn't working

Comments

@Kinmarui
Copy link

Kinmarui commented Jun 28, 2018 •
edited
Loading

workaround is to downgrade mysql to 5.7 in docker-compose.yml
laradock/laradock#1390
@pacoorozco pacoorozco added the bug Something isn't working label Jun 29, 2018
@pacoorozco
Copy link
Owner

This code needs to be upgrsded to Laravel 5.5+, there are strong reasons to do it, and one is this MySQL support. Let me spent some time on it.

pacoorozco added a commit that referenced this issue Jun 30, 2018
@pacoorozco
Fix #15 using MySQL 5.7 docker instead of the latest one
9b05080 
I have modified the way dockers are built. See README.md to see the new
approach.

Closes: #15
@pacoorozco
Copy link
Owner

Hi @Kinmarui

I've updated docker-compose to use MySQL 5.7 instead of latest one. You can test it using dev branch.

In some days I'll merge to master

@Kinmarui
Copy link
Author

Kinmarui commented Jun 30, 2018 •
edited
Loading

Hi @pacoorozco

Thanks for quick feedback and fix.

I applied fix manually as I reported issue and can confirm that application worked. Sadly I don't have now much time to do testing, hopefully I'll get back latter next week.
Side note: I'm running docker on windows with mingw bash shell and had problem with running ./setup.sh since paths were resolved incorrectly, solution was to run docker exec -it bash and manually run commands from setup.sh

@pacoorozco pacoorozco mentioned this issue Aug 10, 2018
Merged
pacoorozco added a commit that referenced this issue Aug 10, 2018
@pacoorozco
Merge pull request #17 from pacoorozco/dev
747b4bd 
Fix continuous integration and issue #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pacoorozco @Kinmarui