Relax dependencies on Radix-UI to SemVer MAJOR releases #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help propagation of bug fixes or features (e.g. React 19 support). If Radix UI frequently breaks semantic versioning, it should be avoided. Pinning packages to patch versions contributes to bundle size bloat.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eps1lon
commented
Jun 24, 2024
| "@radix-ui/react-id": "^1.0.1", | ||
| "@radix-ui/react-primitive": "1.0.3" | ||
| "@radix-ui/react-primitive": "^2.0.0" |
There was a problem hiding this comment.
Couldn't find breaking changes in https://www.radix-ui.com/primitives/docs/overview/releases so I opened radix-ui/primitives#2976
Looks like they just changed the bundler. Doesn't look like anything observable changed: https://npmdiff.dev/@radix-ui%2Freact-primitive/1.0.3/2.0.0/package/dist/index.js/
22 tasks
pacocoursey
approved these changes
Jul 9, 2024
|
@pacocoursey Can you re-approve the workflow? Or, alternatively, only require approval for workflows from people who are new to Github not just new contributors. |
|
@pacocoursey Can this be released or are we waiting on other work before the next release? |
dmagunov
added a commit
to dmagunov/cmdk
that referenced
this pull request
Sep 1, 2024
Relax dependencies on Radix-UI to SemVer MAJOR releases (pacocoursey#278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help propagation of bug fixes or features (e.g. React 19 support).
If Radix UI frequently breaks semantic versioning, it should be avoided. Pinning packages to patch versions contributes to bundle size bloat.