New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type safety for environment attribute values #26

Closed

mversic wants to merge 2 commits into pacman82:master from mversic:attr_values_type_safety

Contributor

mversic commented Jul 18, 2020

Inspired by the #25 PR, this PR increases fixes unknown return values for and increases type safety of attribute values

it is no longer possible to use just any value for ValuePtr argument in SQLSetEnvAttr and SQLGetEnvAttr, rather only values that can be converted to/from EnvAttributeValue newtype can be used. Type safety is increased.
SQLGetEnvAttr can no longer fail silently if driver sets unknown value for ValuePtr as discussed in Unsafe enum usage #12

mversic added 2 commits

July 18, 2020 13:50


          add type safety for environment attribute values

c0ad823


          minor code polishing

553c44f

Owner

pacman82 commented Aug 22, 2020

Close this as new version of odbc-sys abondon enums entirely in favor of newtype integers, if they are used as output arguments.

pacman82 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet