Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pagination problem in commit comments[gitlab] #901

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

mynk8
Copy link
Contributor

@mynk8 mynk8 commented Mar 18, 2025

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • change the get_commit_comments functions to return a full list of commit comments.

Fixes #894

RELEASE NOTES BEGIN

We have fixed pagination problems in ogr's GitlabProject.get_commit_comments().

RELEASE NOTES END

@mynk8 mynk8 force-pushed the pagination-gitlab branch from 2c73110 to a712a4b Compare March 18, 2025 20:24
Copy link
Contributor

@mfocko mfocko force-pushed the pagination-gitlab branch from a712a4b to 145ae8d Compare March 26, 2025 10:43
@mfocko mfocko self-assigned this Mar 26, 2025
Copy link
Contributor

@mfocko mfocko added the mergeit When set, zuul wil gate and merge the PR. label Mar 26, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/88951e8491a748b9992cdb115f854f7d

✔️ pre-commit SUCCESS in 2m 34s

Copy link
Contributor

Pull request merge failed: Required status check "Notes are either written, or there are none / release-notes" is expected.

@mfocko
Copy link
Member

mfocko commented Mar 26, 2025

regate

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a2b0724bdd01454f9b0a4c4f720c8e93

✔️ pre-commit SUCCESS in 2m 36s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b167167 into packit:main Mar 26, 2025
29 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination of GitLab commit comments
2 participants