Skip to content

Fixes qualifier encoding in huggingface test case output expectations #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnmhoran merged 2 commits into from
Oct 30, 2025
Merged

Fixes qualifier encoding in huggingface test case output expectations #718

johnmhoran merged 2 commits into from
Oct 30, 2025

Conversation

@petergardfjall
Copy link
Contributor

@petergardfjall petergardfjall commented Oct 24, 2025

See #644

@petergardfjall petergardfjall mentioned this pull request Oct 24, 2025
Closed
7 tasks
@mjherzog mjherzog changed the title Fixes qualifier encoding in huggingface test case output expecations Fixes qualifier encoding in huggingface test case output expectations Oct 24, 2025
mjherzog
mjherzog approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@mjherzog mjherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

johnmhoran
johnmhoran approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@johnmhoran johnmhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnmhoran johnmhoran merged commit e7dc156 into package-url:main Oct 30, 2025
@petergardfjall petergardfjall deleted the huggingface-tests-qualifier-encoding branch November 4, 2025 11:50
@petergardfjall petergardfjall mentioned this pull request Dec 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjherzog mjherzog mjherzog approved these changes

@johnmhoran johnmhoran johnmhoran approved these changes

+1 more reviewer

@booniepepper booniepepper booniepepper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petergardfjall @mjherzog @johnmhoran @booniepepper