tests: moved/added general tests to spec#696
Merged
mjherzog merged 2 commits intopackage-url:mainfrom Oct 24, 2025
Merged
Conversation
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
changed the title
jkowalleck
changed the title
jkowalleck
commented
Oct 1, 2025
| "expected_failure": false, | ||
| "expected_failure_reason": null | ||
| }, | ||
| { |
Member
Author
There was a problem hiding this comment.
moved to specification-test
| "expected_failure_reason": "Should fail to parse a PURL from invalid purl input" | ||
| }, | ||
| { | ||
| "description": "checks for invalid qualifier keys", |
Member
Author
There was a problem hiding this comment.
moved to specification-test
| "expected_failure_reason": null | ||
| }, | ||
| { | ||
| "description": "a name is required", |
Member
Author
There was a problem hiding this comment.
moved to specification-test
| "expected_failure_reason": "Should fail to parse a PURL from invalid purl input" | ||
| }, | ||
| { | ||
| "description": "a name is required", |
Member
Author
There was a problem hiding this comment.
moved to specification-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since i came up with the original idea to split the test suite(#428)
so that implementations can properly test for the spec and types,
and i've spent a lot of time to properly split the actual needed spec tests, which were broadly ignored in the #514,
here are the "forgotten" and "wrong-categorized" tests.
reviewing all original test cases took me multiple days the last time,
unfortunately, my work was ignored.
I don't have the time to do this again. feel free to do it this time, i am just leaving this PR as a starter.