-
Notifications
You must be signed in to change notification settings - Fork 203
Add validation tests #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add validation tests #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 Thanks! these should be combined in each of the existing JSON files... for instance, for tests/types/conda-validation-tests.json, merge these in https://github.com/package-url/purl-spec/blob/main/tests/types/conda-test.json
And when doing so, please make sure there is no duplicate... you also need to conform to the new schema.
7e01a54 to
07d9554
Compare
schemas/purl-test.schema.json
Outdated
| }, | ||
| "expected_messages": { | ||
| "title": "Expected messages", | ||
| "description": "Validation messages expected for this test. Can be null or a list of strings.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are implementations really expected to produce exactly these text messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matt-phylum re:
Are implementations really expected to produce exactly these text messages?
good point. I have mixed feeling on that alright. One part of me says it would be really nice to have the same validation error messages everywhere. One part of me says it is not critical and may put too much burden on authors. What is your preference?
f645ee5 to
ce67457
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 Thanks! see comments for your review.
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
0124335 to
f3cc7ae
Compare
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
|
@pombredanne @TG1999 We should have an issue to discuss and approve the change to purl-test-schema.json before we apply any other changes. I will draft an Issue based on the limited information in this PR. |
Add tests for validating each PURL type.