Add character-encoding work from qualifiers PR#439
Merged
pombredanne merged 2 commits intomainfrom Apr 2, 2025
Merged
Conversation
Reference: #438 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
johnmhoran
added
PURL encoding
Ecma
Ecma standard
ppkarwasz
reviewed
Mar 29, 2025
Member
|
@johnmhoran can you take #437 into account ? |
Member
Author
|
@jkowalleck Re
I don't know what you mean. Please add detailed comments on this PR in this PR, and please propose language to accompany your comments. It would be helpful if all of us followed that approach whenever possible -- specific language gives us all something concrete to criticize and improve upon. |
Member
|
@jkowalleck re: #439 (comment) I do not think #437 is anyway near ready to be considered :P |
jkowalleck
approved these changes
Apr 2, 2025
pombredanne
approved these changes
Apr 2, 2025
Member
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
This looks fine as it is and will allow to unblock lots of other PRs.
Refining will take place in other PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR begins with a copy of the work we've recently been doing on the "Character encoding" section inside the qualifiers PR (#398), which contains a number of comments relevant to the work on the "Character encoding" section.
References: