This repository has been archived by the owner on May 21, 2024. It is now read-only.
Improve proto generation and cleanup old protos #281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to move proto generation to pachyderm/pachyderm, we've learned a few things and improved the scripts for this process. However, we decided that proto generation and packaging is a bigger project that involves the organization as a whole, so we won't be migrating proto generation from python-pachyderm to pachyderm/pachyderm atm. Related issue here pachyderm/pachyderm#6116.
However, we can still benefit from this exercise and apply some of the improvements:
proto/run
for generating protospython:3.6-slim
We are also adding a new
python_pachyderm.proto.v2
namespace to store the protos generated from pachyderm v2.xWe removed existing generated protos from
python_pachyderm/proto
.Next steps
python_pachyderm/__init__.py
to defer importing a specific proto version, so thatpython_pachyderm.proto.v1
andpython_pachyderm.proto.v2
can co-exist in the same repoRelates to #282