Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JwtCreator for signing and encrypting JWT #32

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Add JwtCreator for signing and encrypting JWT #32

merged 1 commit into from
Nov 6, 2020

Conversation

iriale
Copy link
Contributor

@iriale iriale commented Apr 10, 2020

No description provided.

@iriale iriale force-pushed the pass_JWT_token branch 3 times, most recently from 89a43bc to 9838b44 Compare April 10, 2020 08:21
@ihostage
Copy link
Collaborator

Thank you, @iriale!
I will review this PR as soon as I can!

@ihostage ihostage self-requested a review April 10, 2020 17:23
@leleuj
Copy link
Member

leleuj commented Nov 3, 2020

@iriale Can you sync with master? Thx

@ihostage
Copy link
Collaborator

ihostage commented Nov 3, 2020

@leleuj Sorry about that... This could have been a part of 2.2.0, but I rushed 😞 I think, that after some changes we will need to cut the next release.

@leleuj
Copy link
Member

leleuj commented Nov 3, 2020

No problem, let's sync and review. I'll merge after that and release a v2.2.1.

@ihostage ihostage force-pushed the pass_JWT_token branch 2 times, most recently from 3b10677 to c567bc3 Compare November 4, 2020 12:59
@ihostage ihostage changed the title Pass jwt token [WIP] Add JwtCreator for signing and encrypting JWT Nov 4, 2020
@ihostage ihostage linked an issue Nov 4, 2020 that may be closed by this pull request
Add ability to get JWT token to pass along #23
Closed
@ihostage ihostage force-pushed the pass_JWT_token branch 2 times, most recently from 4be5a9f to 6a1f360 Compare November 4, 2020 17:20
@ihostage ihostage changed the title [WIP] Add JwtCreator for signing and encrypting JWT Add JwtCreator for signing and encrypting JWT Nov 4, 2020
@ihostage ihostage requested a review from leleuj November 4, 2020 17:20
ihostage
ihostage approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@ihostage ihostage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leleuj I think, that this PR ready to review and merge 😄
But don't cut 2.2.1, please. I need time to test a snapshot version in our project. 😉

@leleuj
Copy link
Member

leleuj commented Nov 5, 2020

@ihostage I have one question: why not re-use the JwtGenerator already available in pac4j?

@ihostage
Copy link
Collaborator

ihostage commented Nov 5, 2020

Very good question 👍 Thank a lot, @leleuj!
I updated PR and re-used the JwtGenerator.

@leleuj
Copy link
Member

leleuj commented Nov 5, 2020

I forgot to mention that we also have a JWKHelper, you may want to use it as well. Sorry for the partial information.

@ihostage
Copy link
Collaborator

ihostage commented Nov 5, 2020

Thank you, @leleuj!
I analyzed this class and think, that I will keep com.nimbusds.jose.jwk.JWK#parse as universal parser JWK. Because I don't know kty before JWK will be parsed from config. This method is more useful for our case.

@leleuj leleuj merged commit 9ceb3c7 into pac4j:master Nov 6, 2020
@ihostage ihostage added this to the 2.2.1 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stankevichevg stankevichevg stankevichevg requested changes

@ihostage ihostage ihostage approved these changes

@leleuj leleuj Awaiting requested review from leleuj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

Add ability to get JWT token to pass along
4 participants
@iriale @ihostage @leleuj @stankevichevg