ZeroField #317
Merged
ZeroField #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablosanjose
force-pushed
the
meanfield
branch
from
0862160 to
0c48365
Compare
docstring fixes fix fix
pablosanjose
force-pushed
the
meanfield
branch
from
a5b4426 to
534306e
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 92.46% 92.47%
=======================================
Files 39 39
Lines 6903 6906 +3
=======================================
+ Hits 6383 6386 +3
Misses 520 520 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change
missingas the default value for missing mean field arrays (i.e. the seed non-interacting case) by the singletonzerofield = ZeroField(). It has the property that it returns0.0 Ino matter how it is indexed. This is conceptually cleaner than overloadingBase.getindex(::Missing, ::CellSitePos, ::CellSitePos...)as we did before.We also add some numerical stabilization to the mean field machinery to make the default behaviour more predictable.