Generalize AbstractHamiltonian indexing
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
==========================================
- Coverage 92.55% 92.49% -0.06%
==========================================
Files 37 37
Lines 6176 6184 +8
==========================================
+ Hits 5716 5720 +4
- Misses 460 464 +4 ☔ View full report in Codecov by Sentry. |
fix docstring [skip tests] fix docstring [skip tests]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
With this we provide the same general indexing support for
h::AbstractHamiltonians as forg::GreenSolutions. In particular we can indexhwithSiteselectors,CellSitesorNamedTuples, including any mix of the three. When indexing with anyCellSites, aSparseMatrixCSCis returned (forgit was a denseMatrix), while in all other cases it will be anOrbitalSliceMatrix(like forg).