Skip to content

markersize fix, take 2 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged

markersize fix, take 2 #218

merged 1 commit into from
Oct 20, 2023

Conversation

pablosanjose
Copy link
Owner

Following a suggestion by @SimonDanish in MakieOrg/Makie.jl#3307, we use marker = Circle in scatter!, which should fix the performance issue even for non-scalar markersize

@pablosanjose
Copy link
Owner Author

Again, when MakieOrg/Makie.jl#3281 lands, we could remove this fix, although it is not clear to me if there is any advantage in not using marker = Circle.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4712038) 92.54% compared to head (7f0946c) 92.54%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          34       34           
  Lines        5443     5443           
=======================================
  Hits         5037     5037           
  Misses        406      406           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit 6d5818c into master Oct 20, 2023
@pablosanjose pablosanjose deleted the markersize branch October 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants