-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VegaLite support for non-periodic fields #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsquare phiR problem seems to work refactor more refactor fix almost, but formally clunky works away from true bound states split off devdocs cleanup removed omega0 heuristics change cell default cleanup show method more show fix test
pablosanjose
force-pushed
the
vlplotcells
branch
2 times, most recently
from
January 15, 2021 20:51
353cfef
to
be1df16
Compare
fix fix
pablosanjose
force-pushed
the
vlplotcells
branch
from
January 16, 2021 16:58
110cc6e
to
07356a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 66.92% 62.78% -4.15%
==========================================
Files 16 16
Lines 3232 3450 +218
==========================================
+ Hits 2163 2166 +3
- Misses 1069 1284 +215
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151
This implements the proposal in #151, on top of the PR #150. Together, these allow to plot Greens functions and other fields on unbounded lattices.
As an example we plot the (square of the) local density of states at
ω = 0.01
of a semi-infinite (x>0) zigzag graphene nanoribbon, which is not uniform since the boundary creates a standing wave close to the two zigzag edges.Note that the cost of extending the plot to longer portions of the nanoribbon is negligible, as the 1D Greens function using the single-shot method in #150 makes this essentially free. The real bottleneck for very long nanoribbons is plotting through VegaLite