-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Submodule for pw-link
#15
Conversation
pyproject.toml
Outdated
[tool.flit.metadata] | ||
module = "pipewire_python" | ||
[project] | ||
name = "pipewire_python" | ||
author = "Pablo Diaz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its time to change to pipewire_python's authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point! I've updated to the listed dictionaries style that seems available for Flit and Poetry.
@annaabsi, @kwint, @mrteathyme: I presently have you listed as authors for your contributions. But I'd like to confirm your willingness to be listed here (don't want to put your names "out there" if you don't feel comfortable with it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe only "pipewire_python's authors"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for asking, I rather not be listed as an author. I'm fine with being listed as a contributor, but author sounds like to much recognition for my 5 lines of code and I don't think I will add much to this repo in the future
Also, please change the version to 0.2.2
|
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 65.62% 58.26% -7.37%
==========================================
Files 4 5 +1
Lines 288 484 +196
==========================================
+ Hits 189 282 +93
- Misses 99 202 +103
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Definitely! I wasn't thinking of that. |
@engineerjoe440 the PR is still as draft, tag me when it's ready please |
Sure, @pablodz ! I'll get my branch updated for authors. There's still a point about PRs targeting a |
I'ts ok to target main , I'll run some tests before releasing to pypi |
Thanks, @pablodz! I can't quite make out what's erroring out in the build tests, so if there are things you would like me to address, just let me know! 😄 Thank you! |
Related Issue: #14
Updates:
python
-->Python
pyproject.toml
with common attributesAdditions:
link.py
submodule to supportpw-link