Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Submodule for pw-link #15

Merged
merged 10 commits into from
Feb 9, 2023
Merged

Add Submodule for pw-link #15

merged 10 commits into from
Feb 9, 2023

Conversation

engineerjoe440
Copy link
Collaborator

Related Issue: #14

Updates:

  • Touch up README.md
  • python --> Python
  • Update pyproject.toml with common attributes

Additions:

  • Add link.py submodule to support pw-link
  • Add basic tests for link submodule

pyproject.toml Outdated
[tool.flit.metadata]
module = "pipewire_python"
[project]
name = "pipewire_python"
author = "Pablo Diaz"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its time to change to pipewire_python's authors

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point! I've updated to the listed dictionaries style that seems available for Flit and Poetry.

@annaabsi, @kwint, @mrteathyme: I presently have you listed as authors for your contributions. But I'd like to confirm your willingness to be listed here (don't want to put your names "out there" if you don't feel comfortable with it).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe only "pipewire_python's authors"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking, I rather not be listed as an author. I'm fine with being listed as a contributor, but author sounds like to much recognition for my 5 lines of code and I don't think I will add much to this repo in the future

@pablodz
Copy link
Owner

pablodz commented Jan 8, 2023

Also, please change the version to 0.2.2

__version__ = "0.2.1"

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #15 (8e9afb0) into main (4af72ae) will decrease coverage by 7.36%.
The diff coverage is 47.71%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   65.62%   58.26%   -7.37%     
==========================================
  Files           4        5       +1     
  Lines         288      484     +196     
==========================================
+ Hits          189      282      +93     
- Misses         99      202     +103     
Impacted Files Coverage Δ
pipewire_python/controller.py 65.60% <ø> (ø)
pipewire_python/link.py 47.44% <47.44%> (ø)
pipewire_python/__init__.py 80.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@engineerjoe440
Copy link
Collaborator Author

Also, please change the version to 0.2.2

__version__ = "0.2.1"

Definitely! I wasn't thinking of that.

@pablodz
Copy link
Owner

pablodz commented Jan 14, 2023

@engineerjoe440 the PR is still as draft, tag me when it's ready please

@engineerjoe440
Copy link
Collaborator Author

engineerjoe440 commented Jan 15, 2023

@engineerjoe440 the PR is still as draft, tag me when it's ready please

Sure, @pablodz ! I'll get my branch updated for authors.

There's still a point about PRs targeting a develop branch, did you want me to re-target this PR?

@engineerjoe440 engineerjoe440 marked this pull request as ready for review January 15, 2023 04:26
@pablodz
Copy link
Owner

pablodz commented Jan 15, 2023

I'ts ok to target main , I'll run some tests before releasing to pypi

@engineerjoe440
Copy link
Collaborator Author

Thanks, @pablodz!

I can't quite make out what's erroring out in the build tests, so if there are things you would like me to address, just let me know! 😄

Thank you!

@pablodz pablodz merged commit f231eab into pablodz:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants