Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✍️ All functions planned implemented #1

Merged
merged 1 commit into from
Jun 23, 2021
Merged

✍️ All functions planned implemented #1

merged 1 commit into from
Jun 23, 2021

Conversation

pablodz
Copy link
Owner

@pablodz pablodz commented Jun 23, 2021

All functions implemented and new dictionary created

@pablodz pablodz self-assigned this Jun 23, 2021
@pablodz pablodz added the enhancement New feature or request label Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1 (7172c06) into main (9a7810b) will decrease coverage by 2.13%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
- Coverage   71.29%   69.16%   -2.14%     
==========================================
  Files           4        4              
  Lines         216      227      +11     
==========================================
+ Hits          154      157       +3     
- Misses         62       70       +8     
Impacted Files Coverage Δ
pipewire_python/controller.py 62.41% <31.25%> (-2.81%) ⬇️
pipewire_python/__init__.py 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7810b...7172c06. Read the comment docs.

@pablodz pablodz merged commit 857b598 into main Jun 23, 2021
@pablodz
Copy link
Owner Author

pablodz commented Jun 23, 2021

Absence of tests of new functions!

@pablodz pablodz deleted the dev-functions branch January 1, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant