Skip to content

Conversation

@Sergiobop
Copy link

@Sergiobop Sergiobop commented Jun 30, 2025

  • Changed selectedPresentation to be a model signal
  • Changed example to showcase the change:
 <chrome-picker [control]="chromeColorControl" [selectedPresentation]="2" />

Since i forked the repo and tried to do npm run test but it didn't work, i also updated/fixed the dependencies (karma) and the angular.json (polyfills inside test had to be an array and styles.css didn't exist).

Now npm run test works, but it fails for some Zone stuff i could not fix in this PR:
Zone is not defined in http://localhost:9876/base/test_main.js

I also think we can improve the components a lot, removing lifecycle methods and using some effects/computed signals, but i wanted to contribute with this PR first

I hope you find it useful, thanks!

Closes #98

Sergio Garcia added 2 commits June 30, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change selectedPresentation to be input/model

1 participant