Change selectedPresentation to be input/model #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since i forked the repo and tried to do npm run test but it didn't work, i also updated/fixed the dependencies (karma) and the angular.json (polyfills inside test had to be an array and styles.css didn't exist).
Now npm run test works, but it fails for some Zone stuff i could not fix in this PR:
Zone is not defined in http://localhost:9876/base/test_main.jsI also think we can improve the components a lot, removing lifecycle methods and using some effects/computed signals, but i wanted to contribute with this PR first
I hope you find it useful, thanks!
Closes #98