-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #276
Fixes #276
Conversation
can you be a bit more descriptive about this PR? It would be great if you could refer to the related issues and PRs. |
@parsoyaarihant So the issue was that the get request from now only returned json so it failed it the result is not in json format. This pr fixes that issue. No related issues are there. |
I have few comments about this module:
|
@parsoyaarihant for the 2. Point. I think we only need class for http_get we do not need class based implementation for http_post. And I will take a look at the http error codes. |
Hi @parsoyaarihant about the error codes what we can do is just simply remove the try and except as URL lib will auto throw an exception and it will contain the respected http error codes. What do you think? |
We can do that, I think the documentation and examples should also contain the try and except statements to explain how to use this API |
Thanks |
I was unable to do this fix as I was buzy. Now I have done them.
I have made it a class so that we can do example.text or example.json (for json). If we would have checked each of the lines for example decode json if it startswith("{") and endswith("}") then it will be a very slow process.