Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for renderer attribute in run() function #213

Closed
arihantparsoya opened this issue Aug 2, 2020 · 3 comments
Closed

Add support for renderer attribute in run() function #213

arihantparsoya opened this issue Aug 2, 2020 · 3 comments

Comments

@arihantparsoya
Copy link
Member

Add new attribute called renderer in run() function. The attribute should initiate the renderer based on the value passed.

For example to use vispy: run(renderer="vispy")

In future when new renderers are added, they can be initialised using this attribute.

@Andy-Python-Programmer
Copy link
Contributor

Andy-Python-Programmer commented Aug 2, 2020

I want to work on this issue but if I write the code or even try to run it I get this error:

FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python38-32\\lib\\site-packages\\p5\\sketch\\shaders\\2d\\default2d.vert'

@arihantparsoya
Copy link
Member Author

Can you open a new issue for this? With the code you are trying to run

@Andy-Python-Programmer
Copy link
Contributor

I have just forked and downloaded this repo to work on this issue. No changes are made

hunterwilkins2 added a commit to hunterwilkins2/p5 that referenced this issue Aug 10, 2020
arihantparsoya added a commit that referenced this issue Aug 11, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Added support for renderer attribute in run() #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants