Add max_member_weight to sum_of_members selector semantics (and change to oneof). #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Sep 30, 2022
Co-authored-by: Antonin Bas <[email protected]>
|
Fixed! Thanks for comments! |
|
@jonathan-dilorenzo will you need help with generated files? |
|
Yes please! I gave it another shot, but I have some permission issue when I try it :'(. |
|
@jonathan-dilorenzo done, I updated your branch |
antoninbas
reviewed
Oct 10, 2022
antoninbas
approved these changes
Oct 11, 2022
|
@smolkaj any comment on this? otherwise I'll go ahead and merge it |
smolkaj
approved these changes
Oct 28, 2022
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #396. I found the phrasing a bit awkward. Maybe y'all have better ideas?