Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes for default hit actions for tc backend #4673

Merged
merged 1 commit into from
May 23, 2024

Conversation

Sosutha
Copy link
Contributor

@Sosutha Sosutha commented May 22, 2024

  • Updated tc_may_override hint to be used with default_hit actions

  • Added testcases for tc_may_override hint with default_hit action

* Updated tc_may_override hint to be used with default_hit actions

* Added testcases for tc_may_override hint with default_hit action
@fruffy fruffy added the p4tc Topics related to the P4-TC back end label May 22, 2024
@Sosutha
Copy link
Contributor Author

Sosutha commented May 23, 2024

@fruffy Could you approve this PR, PR is reviewed and approved from P4TC contributor. Need approval from a reviewer with merge access to merge the PR

Copy link
Contributor

@psivanup psivanup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@fruffy
Copy link
Collaborator

fruffy commented May 23, 2024

@fruffy Could you approve this PR, PR is reviewed and approved from P4TC contributor. Need approval from a reviewer with merge access to merge the PR

I have invited komaljai to have write access to approve PRs.

@komaljai komaljai added this pull request to the merge queue May 23, 2024
Merged via the queue into p4lang:main with commit ac9c3f8 May 23, 2024
17 checks passed
@jafingerhut
Copy link
Contributor

@Sosutha Out of curiosity, is there any public documentation, perhaps planned to be included in https://github.com/p4lang/p4c/blob/main/backends/tc/README.md, or linked to from that README, that explains the meanings and restrictions on use of these p4tc-specific annotations?

  • @tc_type
  • @tc_may_override
  • @default_hit
  • @default_hit_const
  • @tc_acl
  • @nummask

I may have missed some, but from some grep'ing through the test programs in testdata/p4tc_samples, those are the ones that I did not recognize as part of the language spec, nor in any public documentation I have come across so far.

@Sosutha
Copy link
Contributor Author

Sosutha commented May 24, 2024

@Sosutha Out of curiosity, is there any public documentation, perhaps planned to be included in https://github.com/p4lang/p4c/blob/main/backends/tc/README.md, or linked to from that README, that explains the meanings and restrictions on use of these p4tc-specific annotations?

  • @tc_type
  • @tc_may_override
  • @default_hit
  • @default_hit_const
  • @tc_acl
  • @nummask

I may have missed some, but from some grep'ing through the test programs in testdata/p4tc_samples, those are the ones that I did not recognize as part of the language spec, nor in any public documentation I have come across so far.

Right now, we do not have any public documentation. But we have plan to add one soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tc Topics related to the P4-TC back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants