Use IR::Annotation::nameAnnotation everywhere instead of hard-coding @name annotation name
#4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation name everywhere
asl
reviewed
Apr 18, 2024
| @@ -32,7 +32,7 @@ control MyVerifyChecksum(inout headers hdr, inout metadata meta) { | |||
| } | |||
| } | |||
|
|
|||
| @my_anno_5 @my_anno_3 control MyIngress(inout headers hdr, inout metadata meta, inout standard_metadata_t standard_metadata) { | |||
| @my_anno_5 @my_anno_3 @name("MyIngress.inner_ctrl") control MyIngress(inout headers hdr, inout metadata meta, inout standard_metadata_t standard_metadata) { | |||
There was a problem hiding this comment.
Why do we have test output change here?
There was a problem hiding this comment.
@asl Apparently, we can't reference IR::Annotation::nameAnnotation in a static container initializer list:
// set of annotations to _not_ propagate during inlining
std::set<cstring> Inline::noPropagateAnnotations = {"name"};
so it must remain hard-coded here.
There was a problem hiding this comment.
Yes, order of static initializers in different TUs is not quite defined.
fruffy
added
the
core
fruffy
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.