Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4TC - Emit 'NoAction' in table actions list in template file #4622

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

komaljai
Copy link
Contributor

Compiler should account for NoAction in table actions list for the template. If the actionList is empty then by default Frontend assumes default_action as 'NoAction'
https://github.com/p4tc-dev/p4tc-e2e/issues/63

Copy link
Contributor

@psivanup psivanup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Contributor

@maheswari-s maheswari-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@fruffy fruffy added the p4tc Topics related to the P4-TC back end label Apr 17, 2024
Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha1830 usha1830 enabled auto-merge April 22, 2024 09:47
@usha1830 usha1830 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into p4lang:main with commit 37c13dc Apr 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tc Topics related to the P4-TC back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants