Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing override in the visitor test compilation unit. #4621

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix missing override in the visitor test compilation unit. #4621

merged 1 commit into from
Apr 16, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Apr 15, 2024

No description provided.

@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Apr 15, 2024
@fruffy fruffy requested review from grg and vlstill April 15, 2024 16:54
grg
grg approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@grg grg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fruffy fruffy added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 9f599a2 Apr 16, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/warning_fix branch April 16, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grg grg grg approved these changes

@vlstill vlstill Awaiting requested review from vlstill

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @grg