Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Outdated links #4618

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Fix: Outdated links #4618

merged 12 commits into from
Apr 29, 2024

Conversation

AdarshRawat1
Copy link
Member

@AdarshRawat1 AdarshRawat1 commented Apr 13, 2024

Changes

Fixing outdated links throughout the repository.

@AdarshRawat1 AdarshRawat1 changed the title Fix: Broken or Outdated links Fix: Outdated links Apr 13, 2024
@fruffy fruffy added the documentation Topics related to compiler documentation. label Apr 13, 2024
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy
Copy link
Collaborator

fruffy commented Apr 17, 2024

This PR is still a draft, is it ready?

@AdarshRawat1
Copy link
Member Author

I'm looking for any other outdated links, that needs to be updated.

@AdarshRawat1
Copy link
Member Author

AdarshRawat1 commented Apr 20, 2024

Help cannot find updated links to following resources

The link here points to an older Version, but bcc has discontinued support for compiling P4 and have removed it here . So should I remove this reference ? or Is there any other location where it can be found (I couldn't find it).

An older version of this compiler for compiling P4_14 is available [here](https://github.com/iovisor/bcc/tree/master/src/cc/frontends/p4).

2nd outdated link

This might not be that significant. current link

p4c/tools/cpplint.py

Lines 4834 to 4835 in 8d21a8b

# Issue 337
# https://mail.python.org/pipermail/python-list/2012-August/628809.html

@AdarshRawat1
Copy link
Member Author

Note

I tried to correct the link to the best of my knowledge, but there might be errors in them. Kindly re-review the links once.

@jafingerhut
Copy link
Contributor

For the outdated link to bcc, it might be nice to explicitly mark it as a "historical reference only". I only suggest that in case someone comes across it in the future and decides to investigate further to make changes that cause it to be supported again, or decides to create a system with older versions of software where they can try it out.

@AdarshRawat1
Copy link
Member Author

For the outdated link to bcc, it might be nice to explicitly mark it as a "historical reference only".

Sure ! So should leave a link to the point of 'bcc' repository before the support for P4 was removed
or remove the link?

@fruffy
Copy link
Collaborator

fruffy commented Apr 24, 2024

For the outdated link to bcc, it might be nice to explicitly mark it as a "historical reference only".

Sure ! So should leave a link to the point of 'bcc' repository before the support for P4 was removed or remove the link?

I would add an annotation saying that this link is for historical reference only.

@AdarshRawat1
Copy link
Member Author

Any suggestions on this outdated link?

2nd outdated link

This might not be that significant. current link

p4c/tools/cpplint.py

Lines 4834 to 4835 in 8d21a8b

# Issue 337
# https://mail.python.org/pipermail/python-list/2012-August/628809.html

@AdarshRawat1 AdarshRawat1 marked this pull request as ready for review April 25, 2024 06:00
@fruffy fruffy added this pull request to the merge queue Apr 29, 2024
@fruffy
Copy link
Collaborator

fruffy commented Apr 29, 2024

Any suggestions on this outdated link?

2nd outdated link

This might not be that significant. current link

p4c/tools/cpplint.py

Lines 4834 to 4835 in 8d21a8b

# Issue 337
# https://mail.python.org/pipermail/python-list/2012-August/628809.html

You can ignore it. We should deprecated cpplint at some point.

Merged via the queue into p4lang:main with commit a425427 Apr 29, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants