restore missing parentheses #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore parentheses that were accidentally dropped from begin call as part of recent code improvements (#4513).
fruffy
approved these changes
Apr 5, 2024
asl
approved these changes
Apr 5, 2024
The test case is the Tofino compiler 🤣 (It's been a couple of months since we last synced with this repo, hence only hitting this issue now.) I'm going to add a test case, either as part of this PR or a separate PR. Tagged you as a reviewer without the tests in case there's a use case that you are aware of where the lack of parentheses was valid. |
|
I've added a single test for ValuesToKeys (which uses MapForKey). It fails to compile without my fix, but compiles and passes with my fix. |
fruffy
added
the
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore parentheses that were accidentally dropped from begin call as part of recent code improvements (#4513).